Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368567 - git log history is incomplete
Summary: git log history is incomplete
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 12:06 EST by Susan McCourt CLA
Modified: 2012-02-02 08:12 EST (History)
0 users

See Also:

Attachments
screenshot (23.93 KB, image/png)
2012-01-13 12:07 EST, Susan McCourt CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-01-13 12:06:18 EST 
I wanted to look at the history of 
bundles/org.eclipse.orion.client.core/web/orion/fileCommands.js

I only see three commits on the file (from this year) when I know there is tons more history.  On the built orion, I see an error when loading the page:

GET http://orion.eclipse.org/gitapi/clone/file/BT/    200 OK   228ms	
built-git-log.js (line 738)

TypeError: a(E) is null
()built-git-log.js (line 691)
undefined = "null"

But on the latest from HEAD (self hosted) I don't get an error but get the same incomplete history.
Comment 1 Susan McCourt CLA 2012-01-13 12:07:52 EST 
Created attachment 209470 [details]
screenshot
Comment 2 Tomasz Zarna CLA 2012-01-26 08:46:26 EST 
I'll try to look at it next week.
Comment 3 Tomasz Zarna CLA 2012-01-30 10:53:24 EST 
Good catch, thanks for filling a bug for it. It's a bug in JGit with a fix being reviewed.
Comment 4 Susan McCourt CLA 2012-01-30 12:39:32 EST 
good timing.  Now that you can get to git log from the editor (related pages menu) I think people are going to hit this more often.
Comment 5 Tomasz Zarna CLA 2012-02-01 11:36:22 EST 
I totally agree, this should be fixed asap. If JGit guys don't accept the fix soon I will probably revert f94cba36c46d09f0471491a549390231c11011ee which used new options in LogCommand, bug 357774.
Comment 6 Szymon Brandys CLA 2012-02-02 05:05:50 EST 
(In reply to comment #5)
> I totally agree, this should be fixed asap. If JGit guys don't accept the fix
> soon I will probably revert f94cba36c46d09f0471491a549390231c11011ee which used
> new options in LogCommand, bug 357774.

+1 for reverting till we have a fix in JGit.
Comment 7 Tomasz Zarna CLA 2012-02-02 08:12:56 EST 
Matthias told me [1] it will take a while til the fix is reviewed and merged, so I've reverted[2] the commit mentioned in comment 5. At the same time I'm reopening bug 357734 to revisit it once the fix is in.

[1] http://dev.eclipse.org/mhonarc/lists/jgit-dev/msg01440.html
[2] 12264bf9cdd0050410bbb31c13a1246d77b212ad