Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368557 - Cannot click Finish when select a RUIHandler template or RUIWidget template
Summary: Cannot click Finish when select a RUIHandler template or RUIWidget template
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Song Fan CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 10:40 EST by Huang Ji Yong CLA
Modified: 2017-02-23 14:20 EST (History)
4 users (show)

See Also:

Attachments
fixed (2.43 KB, patch)
2012-02-17 04:08 EST, Song Fan CLA 		lasher: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Huang Ji Yong CLA 2012-01-13 10:40:39 EST 
Steps to reproduce:
1. Open New Handler wizard.
2. Type in the package and name field.
3. Select RUI handler or RUI Widget
The finish button is disabled
I think it should be enabled.
Comment 1 Brian Svihovec CLA 2012-01-19 11:33:42 EST 
In v .7, a user can open the new Handler wizard, type a name for the handler, and the finish button becomes enabled.  If the user clicks on the RUIHandler or RUIWIdget template type, they have to press the next button before Finish becomes enabled.  If they click on the Basic template type, the Finish button becomes enabled.

In v .8, the Finish button is not immediately enabled if the user types a name, and the user must always press the next button before they can enable the finish button for both the RUIHandler and RUIWidget template.  The finish button does become enabled if the user selects the Basic template.

Theresa and Will, should the Finish button be enabled for the RUIHandler and RUIWidget templates if the user enters a name on the first page?  The other pages of the wizard have values that the user can change, but they are pre-filled and will most likely not be changed.  I agree with Ji Yong that it is frustrating to have to press 'next' just to get the Finish button enabled, but that may be the UI guideline in this situation.
Comment 2 Theresa Ramsey CLA 2012-01-19 15:37:51 EST 
If the user doesn't have to enter any more required info (we have defaults for other info), then Finish should be enabled.  Why did this behavior change in v.8?
Comment 3 Brian Svihovec CLA 2012-01-19 15:44:48 EST 
It appears that in V .7 we were 'half complete', with the Finish button being enabled by default as long as you didn't click on a template.  I assume the fix was to make it more consistent, but the fix went in the 'wrong direction'.

Fan,  If you can create a fix that enables the Finish button for RUIHandler and RUITemplate, attach it to this defect and I will review it and commit the fix on my Friday, otherwise we will defer this until I2.
Comment 4 Song Fan CLA 2012-01-20 03:10:28 EST 
Hi Brian,

I have to fix it after my vacation. Please defer it to I2.

Thanks very much
Comment 5 Song Fan CLA 2012-02-17 04:08:19 EST 
Created attachment 211163 [details]
fixed
Comment 6 Song Fan CLA 2012-02-17 04:30:21 EST 
fixed
Comment 7 Huang Ji Yong CLA 2012-02-20 00:11:59 EST 
Verified in build  0.8.0.v201202190901-1Co-FjuJ6QMNRcrynsZh8h8C