Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368556 - Backport to 3.2.x Last used editor should be set to SystemEditableRemoteFile
Summary: Backport to 3.2.x Last used editor should be set to SystemEditableRemoteFile
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2+   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 249031
Blocks:
  Show dependency tree
 
Reported: 2012-01-13 10:38 EST by David McKnight CLA
Modified: 2012-01-16 11:04 EST (History)
1 user (show)

See Also:
xuanchen: review+

Attachments
backport patch for SystemEditableRemoteFile (2.58 KB, patch)
2012-01-13 10:57 EST, David McKnight CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2012-01-13 10:38:30 EST 
This bug is for the backport of the fix for bug 249031 to the R3_2_maintenance stream.
Comment 1 David McKnight CLA 2012-01-13 10:44:28 EST 
The entire fix for bug 249031 (the changes for SystemViewRemoteFileAdapter.handleDoubleClick()) can't go into the maintenance stream since they require new unavailable APIs for SystemEditableRemoteFile however the change to use IDE.getEditorDescriptor() rather than the IEditorRegistry.getEditorDescriptor() needs to be done since it will have some required recent platform changes.
Comment 2 David McKnight CLA 2012-01-13 10:57:51 EST 
Created attachment 209459 [details]
backport patch for SystemEditableRemoteFile
Comment 3 David McKnight CLA 2012-01-13 10:58:08 EST 
Xuan, could you please review this patch?
Comment 4 Xuan Chen CLA 2012-01-16 10:46:18 EST 
The fix looks good.  Thanks.
Comment 5 David McKnight CLA 2012-01-16 11:04:35 EST 
Thanks Xuan.  I've committed the change to the R3_2_maintenance stream.