Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368521 - Generate separate ModelingAssistant providers for every diagram element
Summary: Generate separate ModelingAssistant providers for every diagram element
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling
Classification: Modeling
Component: Generation / Templates (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2M4   Edit
Assignee: Svyatoslav Kovalsky CLA
QA Contact:
URL:
Whiteboard: Extensibility
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 04:54 EST by Michael Golubev CLA
Modified: 2014-06-03 04:59 EDT (History)
1 user (show)

See Also:
borlander: juno-


Attachments
fixes the subject (27.67 KB, patch)
2012-01-13 05:16 EST, Svyatoslav Kovalsky CLA
borlander: iplog+
borlander: review+
Details | Diff
fixes the subject (11.46 KB, patch)
2012-01-13 05:16 EST, Svyatoslav Kovalsky CLA
borlander: iplog+
borlander: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Golubev CLA 2012-01-13 04:54:58 EST
Actually GMF generates single modeling assistant (MA-) provider that delegates the calls to corresponding generated edit parts. 

This limits an ability to reuse the EditParts code in different diagrams because every generated EditPart class contains the bunch of methods specific for particular context of single diagram plugin. 

Also the MA-related generated EditPart methods are essentially static and does not depend on the particular diagram instance.

=> 

Instead, GMF should generate the separate ModelingAssistant provider for every applicable node/link. All the code from EP should go there to make EP reusable in the context of different diagrams.
Comment 1 Svyatoslav Kovalsky CLA 2012-01-13 05:16:31 EST
Created attachment 209439 [details]
fixes the subject
Comment 2 Svyatoslav Kovalsky CLA 2012-01-13 05:16:50 EST
Created attachment 209440 [details]
fixes the subject
Comment 3 Michael Golubev CLA 2012-05-30 01:17:43 EDT
Deferred
Comment 4 Michael Golubev CLA 2013-11-27 11:25:49 EST
revorked, check https://git.eclipse.org/r/#/c/18665/
Comment 5 Michael Golubev CLA 2013-11-27 11:26:52 EST
Revorked with respect to gerrit comments, new change set is at https://git.eclipse.org/r/#/c/18981/
Comment 6 Michael Golubev CLA 2014-06-03 04:59:41 EDT
Delivered for 3.2.0 (Luna)