Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368473 - Introduce browser-based navigation buttons the tab folders
Summary: Introduce browser-based navigation buttons the tab folders
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M5   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-12 12:39 EST by Remy Suen CLA
Modified: 2012-01-30 17:27 EST (History)
5 users (show)

See Also:

Attachments
screen shot showing arrows (27.04 KB, image/png)
2012-01-24 16:34 EST, David Williams CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2012-01-12 12:39:14 EST 
We want to add arrows to tab folders so that a user can navigate through the list like what they see in a browser.
Comment 1 Remy Suen CLA 2012-01-12 13:45:17 EST 
I've added all of the code in an appendArrows(CTabFolder) method in StackRenderer.

The containment checking logic is not in place as I presume that should be handled by CSS. Once that piece is in we can then toggle these arrows on/off as desired.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=268e47caed76be6023d4a3c022a5a45cfb72d90c
Comment 2 David Williams CLA 2012-01-24 16:34:17 EST 
Created attachment 210015 [details]
screen shot showing arrows

I assume this bug is about the errors as indicated in this screen shot? 

I can "see" them in build I20120123-2200, but they do not seem to work, to change tabs, which is I assume what they are supposed to do? 

(Plus, they do look kind of funny being "on" when the client area is empty, which you mention, but don't know if you are tracking that in another bug?)
Comment 3 David Williams CLA 2012-01-24 16:35:14 EST 
(In case it matters, I'm testing on Linux, 64 bit).
Comment 4 Remy Suen CLA 2012-01-24 17:06:52 EST 
(In reply to comment #2)
> Created attachment 210015 [details]
> screen shot showing arrows
> 
> I assume this bug is about the errors as indicated in this screen shot?

Oleg has opened bug 369531 to discuss the arrows.

> I can "see" them in build I20120123-2200, but they do not seem to work, to
> change tabs, which is I assume what they are supposed to do? 

They're meant to show you the other tabs that you have open like Firefox. Though IE8 seems to have a different behaviour.

> (Plus, they do look kind of funny being "on" when the client area is empty,
> which you mention, but don't know if you are tracking that in another bug?)

Yes, that's in bug 369531.
Comment 5 Remy Suen CLA 2012-01-30 17:27:38 EST 
Verified that the arrows appear with I20120127-1145 on Windows 7.

Bug 369531 will be for the polish.