Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368412 - Adding parameter(s) to a Data Source Explorer for Data Studio connection URL, does not persist.
Summary: Adding parameter(s) to a Data Source Explorer for Data Studio connection URL,...
Status: RESOLVED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: Enablement (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.9.2   Edit
Assignee: Brian Payton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-12 02:37 EST by David CLA
Modified: 2012-02-09 19:43 EST (History)
3 users (show)

See Also:


Attachments
This patches file contains 4 patches. (5.28 KB, patch)
2012-01-13 05:58 EST, David CLA
no flags Details | Diff
New patches in plain text format. (5.28 KB, text/plain)
2012-01-16 00:08 EST, David CLA
no flags Details
This is the first patch. (6.07 KB, patch)
2012-01-16 00:12 EST, David CLA
no flags Details | Diff
This is the second patch. (3.55 KB, patch)
2012-01-16 00:15 EST, David CLA
no flags Details | Diff
This is the third patch. (3.14 KB, patch)
2012-01-16 00:16 EST, David CLA
no flags Details | Diff
This is the fourth pathc. (3.03 KB, patch)
2012-01-16 00:16 EST, David CLA
no flags Details | Diff
This is the patch for iSreies (6.07 KB, patch)
2012-01-20 07:29 EST, David CLA
no flags Details | Diff
This patch is for DB2 LUW (3.58 KB, patch)
2012-01-20 07:30 EST, David CLA
no flags Details | Diff
This is for ZSeries (3.14 KB, patch)
2012-01-20 07:32 EST, David CLA
no flags Details | Diff
This is for Informix (3.03 KB, patch)
2012-01-20 07:32 EST, David CLA
no flags Details | Diff
This is for Zseries (3.14 KB, patch)
2012-01-20 07:41 EST, David CLA
no flags Details | Diff
New_DB2 LUW patch (4.09 KB, patch)
2012-02-07 07:28 EST, David CLA
no flags Details | Diff
New_Informix patch (3.93 KB, patch)
2012-02-07 07:29 EST, David CLA
no flags Details | Diff
New_Informix patch (3.67 KB, text/plain)
2012-02-08 03:45 EST, David CLA
no flags Details
New_Informix patch (3.67 KB, patch)
2012-02-08 03:46 EST, David CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David CLA 2012-01-12 02:37:25 EST
Build Identifier: 20110916-0149

Whenever we are trying to edit the driver definition in the Driver Definition preferences window, the editing information is not persisted in the connection URL of that particular driver while creating the new database connection in Data Source Explorer.



Reproducible: Always

Steps to Reproduce:
1.In any Data Studio product [ Rational Application Developer, InfoSphere Data Architect ..], open Windows --> Preferences --> Data management --> Driver Definitions.

2.Select a particular driver which you want and click Edit button, enter additional parameters and click Apply button.

3.Try to create new database connection.

Actual Results:

The editing information in the Driver Definition preferences window is not persisted in the connection URL of that particular driver.

Expected Results:

The editing information in the Driver Definition preferences window should be persisted in the connection URL of that particular driver.
Comment 1 David CLA 2012-01-13 05:58:34 EST
Created attachment 209445 [details]
This patches file contains 4 patches.

Hi Brian,

I have fixed this issue for RATLC00327075 defect.

This patches file contains four individual patches for  four plugins which are having changes, I did not increment any plugin version and feature version.

I have to push these code changes into ds_const_8.5 and ds_const_3.0.3.6 constellation streams, for that is there any IES patches available?

Please let me know on the same.
Comment 2 David CLA 2012-01-16 00:08:54 EST
Created attachment 209514 [details]
New patches in plain text format.

Hi Brian,

I have attached a new patch file which is in plain text format.
Comment 3 David CLA 2012-01-16 00:12:43 EST
Created attachment 209515 [details]
This is the first patch.
Comment 4 David CLA 2012-01-16 00:15:10 EST
Created attachment 209516 [details]
This is the second patch.
Comment 5 David CLA 2012-01-16 00:16:02 EST
Created attachment 209517 [details]
This is the third patch.
Comment 6 David CLA 2012-01-16 00:16:44 EST
Created attachment 209518 [details]
This is the fourth pathc.
Comment 7 David CLA 2012-01-16 00:18:58 EST
Hi Brian,

I have attached all the individual patches which are in the text/plain format.

Thanks.
Comment 8 Brian Payton CLA 2012-01-20 01:41:42 EST
David, I ran into a problem when testing the fix.  With the patch applied, on DB2 or LUW (the first platform I tested), then the database name gets appended to the end of the connection URL, which makes it invalid.

Without the patch:

  jdbc:db2://9.30.68.165:50002/SAMPLE:retrieveMessagesFromServerOnGetMessage=true;

With the patch:

  jdbc:db2://9.30.68.165:50002/SAMPLE:retrieveMessagesFromServerOnGetMessage=true;SAMPLE;

When the connection is attempted, the Database gives this error message:

com.ibm.db2.jcc.b.nm: [jcc][10165][10051][3.50.152] Invalid database URL syntax: jdbc:db2://9.30.68.165:50002/SAMPLE:retrieveMessagesFromServerOnGetMessage=true;SAMPLE;. ERRORCODE=-4461, SQLSTATE=42815

I did not specify any additional connection parameters.  In fact I did not yet visit the database definition preference page.

I cannot commit this patch as-is.
Comment 9 David CLA 2012-01-20 07:29:04 EST
Created attachment 209808 [details]
This is the patch for iSreies
Comment 10 David CLA 2012-01-20 07:30:37 EST
Created attachment 209809 [details]
This patch is for DB2 LUW
Comment 11 David CLA 2012-01-20 07:32:12 EST
Created attachment 209810 [details]
This is for ZSeries
Comment 12 David CLA 2012-01-20 07:32:58 EST
Created attachment 209811 [details]
This is for Informix
Comment 13 David CLA 2012-01-20 07:41:12 EST
Created attachment 209812 [details]
This is for Zseries
Comment 14 David CLA 2012-01-20 07:47:37 EST
Hi Brian,

I have modified that DB2 LUW code changes, and I have added all the patches once again.

Could you please push the code changes by using the patches which I had added newly [ patch1.txt, patch2.txt, patch4.txt and patch5.txt]?

Please ignore the patch patch3.txt, it is same as the patch patch5.tax, I have added again the same patch by mistakenly.

Please let me know on the same.

Thaks,
David.
Comment 15 Brian Payton CLA 2012-01-24 15:30:30 EST
Hi David, the patch still doesn't test out properly.  Before the patch, the Driver Properties page for an existing DB2 for LUW connection looks like this:

Database: SAMPLE
Host:  9.30.68.165
Port number:  50002
etc.

After the patch, the Driver Properties page looks like this:

Database:  SAMPLE:retrieveMessagesFromServerOnGetMessage=true
Host:  9.30.68.165
Port number:  50002
etc.

and the Connection URL looks like this:

jdbc:db2://9.30.68.165:50002/SAMPLE:retrieveMessagesFromServerOnGetMessage=true;retrieveMessagesFromServerOnGetMessage=true;

That is, the default additional property is appended twice.
Comment 16 David CLA 2012-02-07 07:28:30 EST
Created attachment 210641 [details]
New_DB2 LUW patch
Comment 17 David CLA 2012-02-07 07:29:28 EST
Created attachment 210642 [details]
New_Informix patch
Comment 18 David CLA 2012-02-07 07:37:42 EST
Hi Brian,

Thanks for your help in finding the typical use case.

I have found the same problem in Informix database driver also, I have fixed that problem in both DB2 LUW and Informix databases, i have attached new patches( New_DB2 LUW patch, New_Informix patch).

Could you please test and push the code into open DTP?

Please let me know if you have any concerns on the same.

Thanks,
David.
Comment 19 David CLA 2012-02-08 03:45:15 EST
Created attachment 210711 [details]
New_Informix patch
Comment 20 David CLA 2012-02-08 03:46:03 EST
Created attachment 210712 [details]
New_Informix patch
Comment 21 Brian Payton CLA 2012-02-09 19:43:41 EST
OK, I've finished testing the patches and have checked in the code.  Here's the Git commit record:
http://git.eclipse.org/c/datatools/org.eclipse.datatools.enablement.ibm.git/commit/?id=d8351c2428e7afa6ca041784d1fc3d4ae3c8bc56

I added //$NON-NLS-1$ tags to all the code lines with string literals and updated the plugin version in the MANIFEST.MF file.