Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368371 - Update Deployment Descriptor Editor for better JNDI support
Summary: Update Deployment Descriptor Editor for better JNDI support
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Justin Spadea CLA
QA Contact:
URL:
Whiteboard: jndi
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-11 12:14 EST by Justin Spadea CLA
Modified: 2017-02-23 14:20 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Spadea CLA 2012-01-11 12:14:46 EST
See the design and a mockup in bug 361030. This enhancement will cover updating the editor and the "New SQL Database Binding" wizard page. One possible change for the mockup image is to move the JNDI radio button to be third instead of second, because selecting that option should disable the checkbox section below (the other two radio buttons should re-enable the checkbox section if necessary).

When the new checkbox for defining the data source is unchecked, the section underneath it should be grayed out. The combo should be prefilled with all the classes from the JDBC jar list that implement javax.sql.DataSource and the value in the model will tell us the initial selection.

For the wizard, we need to unhide the widget that lets a user specify a JNDI data source to use. When finishing the wizard, as long as the JNDI option was not chosen the following parameters should be added to the new binding:

deployAsJNDI - value of "true"
jndiName - value of "jdbc/" followed by the database name from the workspace connection (e.g. "jdbc/SAMPLE")
dataSourceClassName - value of the workspace connection's jdbc driver class
Comment 1 Justin Spadea CLA 2012-02-01 13:39:54 EST
The work has been complete, but the UI is a little different than proposed. There is no dataSourceClassName property, and the third radio button to use an existing data source has been removed.
Comment 2 Justin Spadea CLA 2012-02-01 13:43:56 EST
Resolving.
Comment 3 Justin Spadea CLA 2012-02-22 08:53:20 EST
Closing