Community
Participate
Working Groups
Steps: 1) Init a git repo 2) Add a file with one line "something" and commit 3) Modify the file and add the second line "something 2" (no enter at the end) 4) Go to Status View and show the change in the inline compare view It shows: something something Responses for diff and diff uris are ok. It seems that compare view just removes the last character.
I will investigate and fix it. But in a long run(post 0.4), we may want to get the file content for both file URI(new and old). Currently we are generating the new file by diff+old. Szymon, I know that your RTC integration does not provide new file content. Will that be hard to do so?
I'll check this out.
Found the reason: The new file is generated by diff + original file. Unified diff gives "\\ No newline at end of file" tag when there is no new line on either file. Some times the diff contents contains "\r" at end and I had to remove that "\r". But the code to remove this is not checking if a diff line is ending with "\r".
Got a simple fix in origin/bug368250. I've also run all the compare tests without failure. Mark, could you help me on the review?
+1, Libing explained the fix to me and I looked at the code
fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=8565f136c16f67576261eedd3725055e6353a970. Added one more unit test case.
