Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368218 - eclipsebuilder has git ssh url hardcoded
Summary: eclipsebuilder has git ssh url hardcoded
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 368148
  Show dependency tree
 
Reported: 2012-01-10 02:53 EST by Krzysztof Daniel CLA
Modified: 2012-01-12 10:29 EST (History)
3 users (show)

See Also:

Attachments
Fix proposition (778 bytes, text/plain)
2012-01-10 02:53 EST, Krzysztof Daniel CLA 		no flags Details
patch (978 bytes, patch)
2012-01-10 10:09 EST, Kim Moir CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Daniel CLA 2012-01-10 02:53:06 EST 
Created attachment 209246 [details]
Fix proposition

and therefore cannot be run by non-commiters (clone requires password).
Comment 1 Kim Moir CLA 2012-01-10 10:08:56 EST 
The reason we do this is that we invoke some tagging on the repo during the build.  We can't tag the build as a non-commmitter.  Thanks for your patch :-)
Here is releng land I rarely get patches so I really appreciate it.  
However, the patch needs be set via a property, I'll attach a new suggestion.
Comment 2 Kim Moir CLA 2012-01-10 10:09:14 EST 
Created attachment 209264 [details]
patch
Comment 3 Kim Moir CLA 2012-01-12 10:29:10 EST 
Actually it should be more like

<or>
   <equals arg1="${hudson}" arg2="true" />
      <not>
	<equals arg1="${tagMaps}" arg2="true" />
      </not>
</or>

Fixed in HEAD and R3_7_maintenance.