Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368202 - x-friend JDT/JSDT debug in platform debug UI
Summary: x-friend JDT/JSDT debug in platform debug UI
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 17:45 EST by Michael Rennie CLA
Modified: 2012-01-26 16:04 EST (History)
0 users

See Also:

Attachments
patch (5.08 KB, patch)
2012-01-09 17:45 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2012-01-09 17:45:21 EST 
Created attachment 209233 [details]
patch

While generifying JDT debug I found many warnings about illegal access to some of the viewer bits in debug.ui.

We should x-friend JDT debug to these packages.
Comment 1 Michael Rennie CLA 2012-01-09 17:47:23 EST 
Just noticed in the patch that there are some code changes as well...the only thing that should be in there is the manifest changes.
Comment 2 Pawel Piech CLA 2012-01-12 13:32:14 EST 
+1
IMO we should x-fiend freely including for non-open source adaptors.  Since this would give us more of an idea of how many users there are.
Comment 3 Michael Rennie CLA 2012-01-12 13:37:05 EST 
pushed to master: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=55362bc2bb1504b93605cbe07bc7cb3c1a91e17a

> IMO we should x-fiend freely including for non-open source adaptors.

I agree, I will push some more changes to x-friend jsdt.debug
Comment 4 Michael Rennie CLA 2012-01-13 09:59:30 EST 
pushed changes to x-friend JSDT debug: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=d9d41e2e943e7dce0b059d5e9bcd690db7551bc8
Comment 5 Michael Rennie CLA 2012-01-26 16:04:25 EST 
verified in I20120125-1800