Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368181 - [TMF] Common navigator refresh doesn't always execute
Summary: [TMF] Common navigator refresh doesn't always execute
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Francois Chouinard CLA
QA Contact: Francois Chouinard CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 11:49 EST by Patrick Tasse CLA
Modified: 2022-01-13 14:53 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Tasse CLA 2012-01-09 11:49:52 EST
When a refresh is triggered in a common navigator view (e.g. Project Explorer) for a Tracing project, the refresh sometimes fail due to an InvocationTargetException (The resource tree is locked for modifications). This can occur because the refresh triggers a WorkspaceModifyOperation which creates a resourceChanged event that recursively triggers another refresh. The exception is then caught and the refresh does not complete.

The proposed solution is to execute the refresh by executing asynchronously in the UI thread a runnable that iterates through all views in the active page, and for each view that is an instance of a CommonNavigator, retrieve its CommonViewer and invoke the refresh() method.
Comment 1 Patrick Tasse CLA 2012-01-09 12:57:24 EST
Pushed to master branch.

commit 64f985e9df123996bbefa7e764da52552dc3b02c
Comment 2 Patrick Tasse CLA 2012-01-27 12:16:09 EST
Updated solution due to possible NullPointerException when refresh occurs during shutdown. Added null check for active workbench window.

Pushed to master branch.

commit 6ef5cb3bfe66bde629f24b0123c3962844a3dbc4
Comment 3 Francois Chouinard CLA 2012-03-26 13:59:53 EDT
Delivered in 0.10.0