Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368159 - Compare Editor: Author on right side is wrong
Summary: Compare Editor: Author on right side is wrong
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 08:42 EST by Dani Megert CLA
Modified: 2012-06-06 06:45 EDT (History)
1 user (show)

See Also:

Attachments
Picture showing the wrong name (83.82 KB, image/png)
2012-01-09 08:43 EST, Dani Megert CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2012-01-09 08:42:19 EST 
1.3.0.201201082123.

When one compares a file to its previous commit, the compare editor shows the name of that commit even if the file itself did not get changed by this commit. I would expect to see the name of the person who is responsible for the right side content. This correlates to the previous entry in the History view (see attached picture).
Comment 1 Dani Megert CLA 2012-01-09 08:43:22 EST 
Created attachment 209203 [details]
Picture showing the wrong name
Comment 2 Dani Megert CLA 2012-01-09 08:45:02 EST 
I know that technically, the name is correct but from a user that wants to see the change in that file, it is  unexpected.
Comment 3 Kevin Sawicki CLA 2012-01-10 12:39:16 EST 
What menu action did you bring up the compare editor from?

The Compare WIth > Previous Revision option or from the Commit editor?
Comment 4 Dani Megert CLA 2012-01-11 06:44:44 EST 
(In reply to comment #3)
> What menu action did you bring up the compare editor from?
> 
> The Compare WIth > Previous Revision option or from the Commit editor?

From the Commit Editor.

I see that the author is technically correct because the menu says "Compare with Version in Ancestor". Maybe, we should change this to "Compare with Previous Version".
Comment 5 Markus Keller CLA 2012-06-06 06:01:43 EDT 
This is really confusing.
Comment 6 Markus Keller CLA 2012-06-06 06:45:26 EDT 
I wouldn't say the author is technically correct. The right side currently shows the author of the commit, but since the content of the file is shown, the correct author is the the one who authored the content.