Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368147 - Deprecate API in e4 and compat layer that is no longer supported in 4.x (compared with 3.x)
Summary: Deprecate API in e4 and compat layer that is no longer supported in 4.x (comp...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-09 07:40 EST by Christian Campo CLA
Modified: 2019-12-20 08:24 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Campo CLA 2012-01-09 07:40:10 EST
Riena is currently struggling to get itself running on top of e4. Some of the problems are documented in Bug 361133.

One of the major problems that I see is that e4 or the compat layer still contain classes, interfaces or methods that became unfunctional.

By unfunctional I mean it is not the same as deprecated which means that this class or method is no longer recommanded and will become obsolete in the future buts already obsolete.

One example is the presentation API which the e4 team choose to no longer support (one of the major pain points of Riena at the moment, since we have a lot of code in that area).
Another example is Bug 361133 the method createWindowContents in the WorkbenchWindowAdvisor.

I think it would be helpful for everyone porting an application from 3.x to 4.x if those APIs are just gone and not if they still hang around but dont work.

This I think should also include removing them from "compat" layers because even in "compat" mode under e4 those APIs dont work anymore.

This "failfast" approach would me a lot to indentify the methods that needs to be modified in my application
Comment 1 Christian Campo CLA 2012-01-13 10:07:01 EST
After the discussion in the EAC yesterday, the feedback from the Eclipse lead (McQ) was that for binary compatibility reasons they dont want to remove API. What they can do is mark methods and classes as deprecated. The reason being that especially the missing theming API might mean under Eclipse 4.x that you RCP app does not look as you expect, but it runs. Versus if the API is removed it doesnt run.
I accept that policy (although I disagree that this only about styling. Without Presentation some apps like Riena come up with a blank shell and no way to use it anymore).

Still I modify the subject of this bug to what we agreed on and list the part that I see as being candidates for being marked as deprecated.

Deprecated should be the method
WorkbenchWindowAdvisor.createWindowContents(Shell) (bug 361133) which is no longer called

Deprecated should be all classes in the package org.eclipse.ui.presentations since, as I understand, they dont do anything anymore (AbstractPresentationFactory, I PresentablePart, StackPresentation). I believe this package is the core piece of the "presentation/theming API" right ?
Comment 2 Lars Vogel CLA 2012-04-05 03:59:02 EDT
I would love to have old API deprecated. +1 for deprecating the presentation API.
Comment 3 Eclipse Genie CLA 2019-12-20 08:16:56 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Lars Vogel CLA 2019-12-20 08:24:51 EST
createWindowContents is deprecated and the presetation API has been deleted a long time ago.