Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368071 - Dead code in CommonDragAdapterAsistant#getShell()
Summary: Dead code in CommonDragAdapterAsistant#getShell()
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.11 M3   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-06 18:35 EST by Rüdiger Herrmann CLA
Modified: 2019-02-03 12:32 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2012-01-06 18:35:28 EST
It seems that in CommonDragAdapterAsistant#getShell(), in the if branch there is a return statement missing:
  public final Shell getShell() {
    if (contentService != null) {
  	  ((NavigatorContentService) contentService).getShell();
    }
    return PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell();
  }
it should probably read:
  *return* ((NavigatorContentService) contentService).getShell();
Comment 1 Eclipse Genie CLA 2019-01-13 10:39:55 EST
New Gerrit change created: https://git.eclipse.org/r/135018