Community
Participate
Working Groups
This ticket is to track work to add EDL headers to the pom.xml files used for the CBI prototype build for the Eclipse platform.
increasing priority on this ticket
Created attachment 211763 [details] Contains a list of files that changed since upstream M4 for Eclipse 3.x Attached R3_M4-diffs.zip which contains a list of files that changed since upstream M4 for Eclipse 3.x I used "git log" to find the first commit in each repo that was not by Igor to get a difference list of what changed since we pulled the M4 repos. I then used "git diff --stat <commit>" to find a list of all the files that were changed.
Successfully created a script to import the headers into the POM files which requires only 2 steps: 1. Find out what files changed. git diff --name-only 0d06e217afce062498a63489aa159305075cdc42 Replace the commit hash with one before Igor's first commit. 2. Insert headers for i in `cat /tmp/changes` ; do ; sed '1r /home/user/eclipse/EDL_header.txt' < $i > $i.tmp ; mv $i.tmp $i ; done Tested successfully with eclipse.jdt repo so far. Having issues committing to the repo though see my comments in Bug 372738 for further details.
Created attachment 211827 [details] EDL_header.txt
I think we should do the EDL header as a comment in the pom.xml files to denote that file itself is covered under the EDL. This does raise whether we should specify the project license in the pom.xml files. Thanh & I talked about this and it appears it isn't set already. At the moment, I don't have strong feelings about whether it should be set or not but am leaning towards no since the existing headers in other files should already be sufficient and I believe most people consume the Eclipse platform as a p2 repository rather than jar file(s) thus the extra meta data is of dubious value.
/*********************************************************************** * Copyright (c) 2012 Eclipse Foundation. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Distribution License v1.0 * which accompanies this distribution, and is available at * http://www.eclipse.org/org/documents/edl-v10.php * * Contributors: * Igor Fedorenko - initial implementation ***********************************************************************
Headers have been added in both the R4 and R3 repositories.
