Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367970 - Review Code Consistency in terms of Quality, Formatting, and Documentation
Summary: Review Code Consistency in terms of Quality, Formatting, and Documentation
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.0 RC2   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 361024 372252
Blocks:
  Show dependency tree
 
Reported: 2012-01-05 13:50 EST by Simon Kaegi CLA
Modified: 2013-06-17 14:22 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2012-01-05 13:50:22 EST 
As we get closer to a 1.0 release we need to take some time to look at the code in terms of ensuring we have consistency for formatting, documentation, and the quality of the code (e.g. all code must be reviewed by at least one other committer). We want the Orion code-base to be easily understandable and ensuring consistency will make both maintenance and evolving more simple without requiring the original author to always be involved.
Comment 1 Susan McCourt CLA 2012-01-05 14:09:40 EST 
- it would be good to look for copied code and try to refactor, I know we have lots of copied code across various "navigator" tables, etc.
Comment 2 Susan McCourt CLA 2012-02-22 11:31:44 EST 
(In reply to comment #1)
> - it would be good to look for copied code and try to refactor, I know we have
> lots of copied code across various "navigator" tables, etc.

opened bug 372252 for this.
Comment 3 Susan McCourt CLA 2012-02-22 11:35:19 EST 
another place to look is search "TODO"
Comment 4 Ken Walker CLA 2012-02-23 11:17:38 EST 
bogus and hack
Comment 5 Simon Kaegi CLA 2013-06-17 14:22:49 EDT 
Done for this release