Community
Participate
Working Groups
see the specification on 366706 for validation details In addition The egldd AS400Connection must not be part of the UI core it must be contributed by one one of the jtopen plugins.
Changing to .8 I2. Let me know if this does not match what you are thinking.
Hi Joe, Is the egldd entry for AS400 connection like below: For JNDI: <binding name="news" type="edt.binding.as400connection" uri="jndi://as400connection1" useURI="true"> </binding> For AS400Connection: <binding name="news" type="edt.binding.as400connection" uri="" useURI="false"> <parameters> <parameter name="system" value="ip"/> <parameter name="userId" value="abc"/> <parameter name="password" value="abc"/> <parameter name="getConnectionFromSessionPool" value="true"/> </parameters> </binding>
(In reply to comment #2) > Hi Joe, > > Is the egldd entry for AS400 connection like below: > > For JNDI: > <binding name="news" type="edt.binding.as400connection" > uri="jndi://as400connection1" useURI="true"> > </binding> > > For AS400Connection: > <binding name="news" type="edt.binding.as400connection" uri="" > useURI="false"> > <parameters> > <parameter name="system" value="ip"/> > <parameter name="userId" value="abc"/> > <parameter name="password" value="abc"/> > <parameter name="getConnectionFromSessionPool" value="true"/> > </parameters> > </binding> This looks good, but there are a couple of changes. I'm in the process of updating the specification, the impact to your code is minimal. Here are spec changes: - JNDI requires websphere so there would be few users and more importantly we don't have the time to complete the development and testing so it will not be implemented in 0.8.0. - The parameter getConnectionFromSessionPool is removed. - Add the parameter library type string. I'd like to change as400connection to ibmiconnection. The pattern I've been using is: Use AS400 when a item refers to a JTOpen class or a JTOpen java doc, I use IBMi when it may be some other object. In this case a jndi connection is not an AS400 object.
Created attachment 210487 [details] Patch Here is a patch for this enhancement. Tony, please help review it. Thanks a lot.
It looks like this is working, but I see a couple of small problems. - In IBMiBindingWizardPage.createPasswordControl the method is doing fPasswordField.setText(getConfiguration().getUserId()) it should be using the password field fPasswordField.setText(getConfiguration().getPassword()). - The label on the password field appears as User. IBMiConnectionBindingDetailPage.createPasswordControl uses it should use Messages.LabelPassword. Can you commit this so we can incorporate it into a build?
Hi Jeo, Thanks a lot for the review. I've checked in the patch, but I didn't release the new plugin (org.eclipse.edt.ide.jtopen), because I didn't see you release any JTOpen plugins, let me know if I should release it. Thanks.
Close this one, please open defect if you see any issue. Thanks.
verified
