Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367942 - setPDEBuildPath does nothing currently
Summary: setPDEBuildPath does nothing currently
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: eclipse-build (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Packaging Tools Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-05 08:00 EST by Krzysztof Daniel CLA
Modified: 2012-01-05 10:54 EST (History)
2 users (show)

See Also:

Attachments
First version of the patch (3.32 KB, patch)
2012-01-05 08:21 EST, Krzysztof Daniel CLA 		no flags Details | Diff
Fix in line with Alex suggestions (894 bytes, patch)
2012-01-05 09:51 EST, Krzysztof Daniel CLA 		akurtakov: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Daniel CLA 2012-01-05 08:00:41 EST 
I think it is a side effect of fix for bug 366698 and earlier patches.

It looks like the setPDEBuildPath was designed to use PDE of Eclipse that was build. Maybe it is time to use PDEBuild from bootstrap?
Comment 1 Krzysztof Daniel CLA 2012-01-05 08:01:54 EST 
I forgot to mention setPDEBuildPath does nothing because it cannot discover PdeBuild in the build/<label>/installation folder, and therefore tests cannot be built.
Comment 2 Alexander Kurtakov CLA 2012-01-05 08:14:17 EST 
I have some concerns about using the bootstrap pde.build for running tests - it should be kept to the minimum and used only for building the sdk. The more we use it the harder to modify it it will become.
The correct fix for me seems to fix setPDEBuildPath to find pde.build in dropins which is the default now.
Comment 3 Krzysztof Daniel CLA 2012-01-05 08:21:01 EST 
Created attachment 209071 [details]
First version of the patch

Eclipse is built correctly. 
I am not sure about tests - build ends with success.
Comment 4 Krzysztof Daniel CLA 2012-01-05 09:51:31 EST 
Created attachment 209074 [details]
Fix in line with Alex suggestions
Comment 5 Alexander Kurtakov CLA 2012-01-05 10:54:31 EST 
Thanks.
Applied.