Community
Participate
Working Groups
As explained in http://www.eclipse.org/forums/index.php/m/774303/#msg_774303, it would be nice if CDO's behaviour regarding the notification of adapters during loading could be parametrized to be switched on, to mimic the behaviour of XMI resources for exemple.
I'm adding the following new API: - CDOView.Options.isLoadNotificationEnabled() - CDOView.Options.setLoadNotificationEnabled(boolean) The default value is false (i.e. the former behaviour)
commit 7071cb1cd5f9a14529f3be4c8ad319848aa94715
Please test carefully because we don't have tests for this in our suites (other than regression tests)!
Created attachment 210149 [details] Patch - Failing Test case for Load notification API Here's the requested patch. It adds org.eclipse.emf.cdo.tests.LoadNotificationTest, that is failing, because constuctor-time-registered adapters are not notified.
Alexandre, I can't seem to apply your patch: C:/Users/Stepper/AppData/Local/Temp/~attachment-5480502489365861950.patch:841: trailing whitespace. * C:/Users/Stepper/AppData/Local/Temp/~attachment-5480502489365861950.patch:872: trailing whitespace. * C:/Users/Stepper/AppData/Local/Temp/~attachment-5480502489365861950.patch:879: trailing whitespace. * C:/Users/Stepper/AppData/Local/Temp/~attachment-5480502489365861950.patch:887: trailing whitespace. * C:/Users/Stepper/AppData/Local/Temp/~attachment-5480502489365861950.patch:897: trailing whitespace. * error: patch failed: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/legacy/model6/Model6Factory.java:18 error: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/legacy/model6/Model6Factory.java: patch does not apply error: patch failed: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/legacy/model6/Model6Package.java:23 error: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/legacy/model6/Model6Package.java: patch does not apply error: patch failed: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/legacy/model6/impl/Model6FactoryImpl.java:20 error: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/legacy/model6/impl/Model6FactoryImpl.java: patch does not apply error: patch failed: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/legacy/model6/impl/Model6PackageImpl.java:20 error: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/legacy/model6/impl/Model6PackageImpl.java: patch does not apply error: patch failed: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/model6/Model6Factory.java:15 error: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/model6/Model6Factory.java: patch does not apply error: patch failed: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/model6/Model6Package.java:24 error: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/model6/Model6Package.java: patch does not apply error: patch failed: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/model6/impl/Model6FactoryImpl.java:18 error: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/model6/impl/Model6FactoryImpl.java: patch does not apply error: patch failed: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/model6/impl/Model6PackageImpl.java:25 error: plugins/org.eclipse.emf.cdo.tests.model6/src/org/eclipse/emf/cdo/tests/model6/impl/Model6PackageImpl.java: patch does not apply Nevertheless I've managed to modify model6.ecore and the generated GImpl classes: commit 7005d35ba2bb85c295b2e25d1126e4a539f24036 Can you please attach your test case in plain Java format?
Closing.
