Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367855 - [terminal] TerminalActionPaste uses wrong icon for disabled state
Summary: [terminal] TerminalActionPaste uses wrong icon for disabled state
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.0   Edit
Assignee: dsdp.tm.core-inbox CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-04 10:08 EST by Anton Leherbauer CLA
Modified: 2015-05-22 12:06 EDT (History)
2 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2012-01-05 10:30 EST, Anton Leherbauer CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2012-01-04 10:08:10 EST 
In the constructor of TerminalActionPaste the arguments to setupAction for enabledImage and disabledImage are reversed.
For some reason this seems to do no harm if the action is added to a menu, but when it is added to a toolbar, the button looks enabled although the action is in disabled state.
Comment 1 Anton Leherbauer CLA 2012-01-05 10:30:32 EST 
Created attachment 209079 [details]
Patch

This fixes the icons for the paste action.
Comment 2 Uwe Stieber CLA 2015-05-07 07:49:34 EDT 
Fixed in TM Terminal 4.0
Comment 3 Uwe Stieber CLA 2015-05-07 07:49:41 EDT 
.
Comment 4 Martin Oberhuber CLA 2015-05-22 12:06:36 EDT 
Comment on attachment 209079 [details]
Patch

Slightly different code was used to fix this issue:

http://git.eclipse.org/c/tm/org.eclipse.tm.terminal.git/commit?id=08844f654a4935c830aa37d60dc720348c6b5447

Thus marking attachment as obsolete.