Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367841 - BPELTextTransferDropTargetListener blocks additional DropListeners
Summary: BPELTextTransferDropTargetListener blocks additional DropListeners
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BPEL (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-04 08:06 EST by Mickael Istria CLA
Modified: 2022-10-03 11:12 EDT (History)
2 users (show)

See Also:

Attachments
Patch that makes BPELTextTransferDropTargetListener disabled when necessary (1.42 KB, patch)
2012-01-04 08:11 EST, Mickael Istria CLA 		bbrodt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2012-01-04 08:06:06 EST 
BPELTextTransferDropTargetListeners.isEnabled always returns true, even with it is in error or if it does not support the dragSource.
Then, if one provides additional listeners to the viewer, they won't be used since the BPELTextTransferDropTargetListener always handles (badly) the DND.

BPELTextTransferDropTargetListener should be fixed in order to get the isEnabled method returning false when the BPELTextTransferDropTargetListener cannot perform the drop.
Comment 1 Mickael Istria CLA 2012-01-04 08:07:20 EST 
We have this use case for PetalsStudio, and it prevent us from adding DropListeners (by adding a WorkbenchPartListener to add DropListeners when opening a bPELEditor).
Comment 2 Mickael Istria CLA 2012-01-04 08:11:21 EST 
Created attachment 209000 [details]
Patch that makes BPELTextTransferDropTargetListener disabled when necessary

This patch fixes the "createRequest" to ask isEnabled to check for command enablement in case of error. Since the request is incomplete (missing factory), the created command is not executable and isEnabled returns false.

This fixes this blocking bug for our use case.
Comment 3 Vincent Zurczak CLA 2012-01-05 11:24:58 EST 
The patch was applied on the master branch.