Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367808 - Cleanup new warnings for missing @Override for Java 6
Summary: Cleanup new warnings for missing @Override for Java 6
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 8.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.1.0   Edit
Assignee: Marc Khouzam CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-03 22:03 EST by Marc Khouzam CLA
Modified: 2012-02-23 11:33 EST (History)
1 user (show)

See Also:

Attachments
Patch for dsf and dsf.ui (145.83 KB, patch)
2012-01-03 23:01 EST, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2012-01-03 22:03:07 EST 
Java 6 shows a warning of there is no @Override tag on a method that implements a method of an interface.  Now that we require Java 6 for the DSF plugins, we have a bunch of those warnings.

I will post a patch to add the missing @Override.
Comment 1 Marc Khouzam CLA 2012-01-03 23:01:26 EST 
Created attachment 208978 [details]
Patch for dsf and dsf.ui

Here is the patch.  I created with 0 lines of context to make it shorter as the patch was totally mechanical.
Comment 2 Marc Khouzam CLA 2012-01-03 23:05:53 EST 
I have committed the patch to master.

Pawel, I won't ask for an official review because it is a painfully boring review.  However, I did the fixes almost entirely using quick-fix shortcuts, so I feel it is pretty safe.

I also ran the DSF-GDB JUnit tests with GDB 7.3 and everything passed.

The commit is 463d52d01b28bac1dad93494d13a8e94b242c952, in case one wants to create a patch with more lines of context.
Comment 3 Marc Khouzam CLA 2012-01-03 23:08:19 EST 
BTW, this removes 1007 warnings