Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367804 - ChangeRequest_Selector.jsp JSON response is missing the "oslc-response:" text string within the select method
Summary: ChangeRequest_Selector.jsp JSON response is missing the "oslc-response:" text...
Status: CLOSED FIXED
Alias: None
Product: Lyo
Classification: Technology
Component: RIO (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Sanjay Joshi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-03 17:50 EST by Sanjay Joshi CLA
Modified: 2015-03-09 09:50 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sanjay Joshi CLA 2012-01-03 17:50:36 EST
Build Identifier: Version: Indigo Release Build id: 20110615-0604

Within the latest RIO github codebase, the CM RIO file "changerequest_selector.jsp" contains a bug within its select function definition.  Specifically, the variable for the oslcResponse is missing a parent tag for "oslc-response:".

Current:  var oslcResponse = '{ "oslc:results": [ ' +  
			' { "oslc:label":"' + option.text + '", "rdf:resource":"' + option.value + '"} ' + 
		' ]}';

Suggested:  var oslcResponse = 'oslc-response:{ "oslc:results": [ ' +  
			' { "oslc:label":"' + option.text + '", "rdf:resource":"' + option.value + '"} ' + 
		' ]}';

Without this fix, the selector dialog does not appropriately notify the parent consuming window about the data for the selection.  The tutorial and workshop materials all indicate this tag, however the RIO code seems to be missing it.

Reproducible: Always

Steps to Reproduce:
1.  Follow the workshop steps and attempt to associate the CM RIO with RTC
2.  Utilize the selection dialog and attempt to hit the OK button.
3.  Validate that nothing occurs within the RTC parent window.
Comment 1 Sanjay Joshi CLA 2012-01-04 10:25:29 EST
I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.

Commit:  https://github.com/joshisa/lyo.rio/commit/2ddde9eda3e1984b9882e2a7357380116e493296
Comment 2 Michael Fiedler CLA 2012-01-04 13:51:55 EST
The AM and RM RIOs need to be updated too.   I have a commit to address this.
Comment 4 Samuel Padgett CLA 2015-03-09 09:50:55 EDT
Bulk update: Closing out Lyo bugs fixed long ago. Feel free to reopen if you feel your bug was closed in error.