Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367779 - Embedded editor example is not working
Summary: Embedded editor example is not working
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Editor (show other bugs)
Version: 0.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-03 12:24 EST by Mark Macdonald CLA
Modified: 2012-01-20 15:04 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-01-03 12:24:09 EST 
Orion 2012-02-02-2230

1. Start Orion on localhost
2. Go to http://localhost:8080/examples/editor/embeddededitor.html
3. There's a JS error. The editor doesn't load.

Uncaught TypeError: Object require,orion/textview/textView,orion/textview/keyBinding,examples/textview/textStyler,orion/editor/textMateStyler,orion/editor/htmlGrammar,orion/editor/editor,orion/editor/editorFeatures,orion/editor/contentAssist,orion/editor/jsContentAssist,orion/editor/cssContentAssist has no method 'split'
Comment 1 Susan McCourt CLA 2012-01-03 12:40:12 EST 
Mark, do you want to take this one since you are most active on the editor/client side?  (Or is someone working on CSS content assist?)
Comment 2 Felipe Heidrich CLA 2012-01-03 12:47:08 EST 
the changes of http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6ba402f52bc6e143a94dd1a80ee3b77b8c59d0a9 got lost at some point

besides, contentAssist.addProvider apparently got renamed to setProvider too
Comment 3 Mark Macdonald CLA 2012-01-03 12:52:45 EST 
(In reply to comment #2)
> besides, contentAssist.addProvider apparently got renamed to setProvider too

This one is my fault, I'll fix it.
Comment 4 Felipe Heidrich CLA 2012-01-03 12:57:34 EST 
I put back the change to embeddededitor.html

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=31e87ce55d71312e8c0ac73a535d7d5a155ea337

for some reason it was removed at this commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e6243921f2ef1567acb111e4000ccc526f5309ba

Malgorzata, was the change to minimaleditor.html and embeddededitor.html accidental ?
Comment 6 Malgorzata Janczarska CLA 2012-01-04 04:18:51 EST 
(In reply to comment #4)
> I put back the change to embeddededitor.html
> 
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=31e87ce55d71312e8c0ac73a535d7d5a155ea337
> 
> for some reason it was removed at this commit:
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e6243921f2ef1567acb111e4000ccc526f5309ba
> 
> Malgorzata, was the change to minimaleditor.html and embeddededitor.html
> accidental ?

This is a merge commit, so I'm sure it's just an error while merging.
Sorry about that!
Comment 7 Felipe Heidrich CLA 2012-01-04 13:58:47 EST 
This is fixed, right ?
Comment 8 Mark Macdonald CLA 2012-01-04 14:18:43 EST 
(In reply to comment #7)
> This is fixed, right ?

Yes