Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367749 - Error handling in ProjectSetImporter.importProjectSet is wrong
Summary: Error handling in ProjectSetImporter.importProjectSet is wrong
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-03 07:18 EST by Dani Megert CLA
Modified: 2012-01-03 10:13 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2012-01-03 07:18:43 EST 
3.8 M4.

The error handling in ProjectSetImporter.importProjectSet needs to be improved: it collects the TeamExceptions but if some other exceptions happen (like an assertion failure) then the TeamExceptions are swallowed i.e. not reported.

Also, CVSProjectSetCapability.addToWorkspace should probably covert the IAE into a TeamException.


Test Case:
1. install 3.8 M4 plus EGit
2. start with new workspace
3. import team project set from attachment 208048 [details]
Comment 1 Dani Megert CLA 2012-01-03 09:19:41 EST 
The biggest bug is that referenceStrings is not cleared when an exception happens. As a result, the next provider tries to load project references from the previous one and then fails badly.
Comment 2 Dani Megert CLA 2012-01-03 10:13:05 EST 
Fixed in master: 45e2a2fe42c326895aaa0a4323b9650225fa7863