367744 – Verify if the JAVA_HOME is set before build starts

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367744 - Verify if the JAVA_HOME is set before build starts

Summary: Verify if the JAVA_HOME is set before build starts

Status:	RESOLVED FIXED

Alias:	None

Product:	Linux Tools
Classification:	Tools
Component:	eclipse-build (show other bugs)
Version:	unspecified
Hardware:	PC Linux

Importance:	P3 enhancement (vote)
Target Milestone:	1.0
Assignee:	Krzysztof Daniel
QA Contact:	Alexander Kurtakov

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-01-03 06:32 EST by Krzysztof Daniel
Modified:	2019-05-17 05:24 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Patch proposition (676 bytes, patch) 2012-01-03 09:41 EST, Krzysztof Daniel	krzysztof.daniel: review-	Details \| Diff
Patch v2 (815 bytes, patch) 2012-01-03 11:13 EST, Krzysztof Daniel	no flags	Details \| Diff
Patch v2 - proper diff (860 bytes, patch) 2012-01-03 11:17 EST, Krzysztof Daniel	no flags	Details \| Diff
Patch v3 - better naming (874 bytes, patch) 2012-01-03 11:18 EST, Krzysztof Daniel	no flags	Details \| Diff
Patch v4 in git format (1.26 KB, patch) 2012-01-03 11:31 EST, Krzysztof Daniel	overholt: iplog+	Details \| Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Krzysztof Daniel

2012-01-03 06:32:54 EST

because it will fail otherwise

Comment 1 Krzysztof Daniel

2012-01-03 09:41:20 EST

Created attachment 208937 [details]
Patch proposition

A check if the java home is really set.

Comment 2 Krzysztof Daniel

2012-01-03 11:13:58 EST

Created attachment 208942 [details]
Patch v2

Comment 3 Krzysztof Daniel

2012-01-03 11:17:01 EST

Created attachment 208943 [details]
Patch v2 - proper diff

Comment 4 Andrew Overholt

2012-01-03 11:17:21 EST

This looks good to me.  Would it be possible to provide a git-formatted patch so that you'll remain as the author?  Thanks!

Comment 5 Krzysztof Daniel

2012-01-03 11:18:25 EST

Created attachment 208944 [details]
Patch v3 - better naming

Comment 6 Krzysztof Daniel

2012-01-03 11:31:37 EST

Created attachment 208945 [details]
Patch v4 in git format

Comment 7 Andrew Overholt

2012-01-03 16:24:22 EST

Thanks for the patch.  Pushed in 0c3a5d1:  http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.eclipse-build.git/commit/?id=0c3a5d17d9aeeadf57141aeaba3b65d1ff533584 (not working for some reason).

Comment 8 Andrew Overholt

2012-01-04 14:09:08 EST

Setting target milestone.