Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367742 - [nano] org.eclipse.virgo.kernel.userregion configuration included in nano
Summary: [nano] org.eclipse.virgo.kernel.userregion configuration included in nano
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: runtime (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.5.0.M02   Edit
Assignee: Borislav Kapukaranov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-03 06:23 EST by Glyn Normington CLA
Modified: 2012-01-06 11:26 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Glyn Normington CLA 2012-01-03 06:23:53 EST 
This seems inappropriate since nano does not include a user region.
Comment 1 Glyn Normington CLA 2012-01-03 06:24:30 EST 
This can be observed by using jconsole and looking under MBeans->org.eclipse.virgo.kernel->Configuration
Comment 2 Borislav Kapukaranov CLA 2012-01-03 07:44:20 EST 
Note that the properties file itself is NOT included in /config so there must be someone that creates this configuration programatically.
Comment 3 Glyn Normington CLA 2012-01-03 08:58:43 EST 
(In reply to comment #2)
> Note that the properties file itself is NOT included in /config so there must
> be someone that creates this configuration programatically.

Agreed. CommandLinePropertiesSource seems to be the source as the single property appears in jconsole: commandLineArtifacts which appears to have an empty string value.
Comment 4 Borislav Kapukaranov CLA 2012-01-06 04:55:57 EST 
(In reply to comment #3)
> Agreed. CommandLinePropertiesSource seems to be the source as the single
> property appears in jconsole: commandLineArtifacts which appears to have an
> empty string value.

Do you have any idea why CommandLinePropertiesSource binds this configuration with one empty-valued property? Can this behavior be removed?
Comment 5 Glyn Normington CLA 2012-01-06 05:05:23 EST 
(In reply to comment #4)
> (In reply to comment #3)
> > Agreed. CommandLinePropertiesSource seems to be the source as the single
> > property appears in jconsole: commandLineArtifacts which appears to have an
> > empty string value.
> 
> Do you have any idea why CommandLinePropertiesSource binds this configuration
> with one empty-valued property? Can this behavior be removed?

No, sorry. I hope this behaviour can be removed without much impact.
Comment 6 Borislav Kapukaranov CLA 2012-01-06 11:26:53 EST 
It seems this default value can be safely removed, I tested that on a VK instance. 
I guess it was put there precautionary to avoid any chance of NPEs in case the StringUtils that are handling this value won't cope with null string values. Apparently this is not the case.

Fixed in commit 3515ad8 of the Nano repository.