Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367643 - [TCF][Process] Auto-refresh should apply to process monitor only
Summary: [TCF][Process] Auto-refresh should apply to process monitor only
Status: CLOSED DUPLICATE of bug 368321
Alias: None
Product: TCF
Classification: Tools
Component: Target (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: William Chen CLA
QA Contact: Uwe Stieber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-30 02:52 EST by Uwe Stieber CLA
Modified: 2012-01-11 04:19 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Stieber CLA 2011-12-30 02:52:09 EST 
IMO, the auto-refresh setting should apply to the editor based process monitor only. If the user has the processes added to the tree content, it should be either always full manual refresh, or there has to be a way to configure the auto-refresh setting from the tree as well. Otherwise it is confusing.

PS: If the auto-refresh setting applies to the tree as well, the refresh job should be started (if required) without opening the process monitor first.
Comment 1 William Chen CLA 2011-12-30 04:15:32 EST 
Hi Uwe,

Now the refreshing job is started without opening the process monitor. Actually the tree's data model is shared with Process Monitor. The refresh job starts without knowing the existence of the  process tree and process monitor. It runs standalone from the two viewers. Once it has a refreshing change, it notifies the viewers which is listening to it. Then the viewers in interest will refresh itself. 

Now that the auto refreshing settings are meant to apply to the refreshing job, it applies to the tree as well as Process Monitor since they are actually observers of the refreshing job.

-William
Comment 2 Uwe Stieber CLA 2011-12-30 07:54:44 EST 
I'm not a big believer in having the tree auto-refreshing. The UI tends to flicker and the UI thread is kept busy on a high load. This has bad influence on debug stepping performance, which is number one priority. I have no problem that the tree and the monitor are sharing the same model (== good), but having the tree auto-refreshing is not a good idea. In fact, in Workbench similar functionality got never accepted.

I'm OK with the user to have the option to enable the auto-refresh in the tree if he really likes, but I think the requirements here are

- The tree should not auto-refresh by default (must be explicitly enabled by the user)
- The monitor should auto-refresh by default (IMO)
- The tree auto-refresh needs to be configurable even if the process monitor is closed. It's not intuitive for the user to set the refresh rate on the editor tab and that influences the tree.

Let's discuss in our next weekly meeting too.
Comment 3 William Chen CLA 2012-01-11 04:19:12 EST 

*** This bug has been marked as a duplicate of bug 368321 ***