Community
Participate
Working Groups
Created attachment 208863 [details] quick profile screen shot 1.clone https://johnjbarton@github.com/johnjbarton/inspector.git 2.Open the navigator page, open twisty for front-end/ folder. 3.open inspector.html In Chrome 17.0.963.12 dev-m, one CPU pegs and the window remains blank. I don't know if it is making progress. I opened a new tab, opened devtools, then pasted the inspector.html URL in. The window painted, I got the usual errors in the console, then 100% and nothing works. Ok but I can profile, see attachment
I tried to uninstall jslintPlugin, but it won't go away.
This sounds like the same bug: https://github.com/douglascrockford/JSLint/issues/67 It's been fixed on jslint.com, but not in the version of JSLint that Orion uses. A workaround is to move the copyright notice underneath the DOCTYPE.
The workaround works, except that you have to do it off-line (since you can't user Orion), and I can't commit the workaround back to the original source. This problem is embarrassing because it means Cloud9 can edit Chrome devtools but Orion cannot edit it. What needs to be done to get the new version of JSLint installed?
(In reply to comment #3) > This problem is embarrassing because it means Cloud9 can edit Chrome devtools > but Orion cannot edit it. What needs to be done to get the new version of > JSLint installed? I agree, this pretty bad. We need to get legal approval to use the new version of JSLint. I've just kicked off the process.
I've created a pull request for a patch that might address this in the current JSLint we are using - it addresses the referenced bug ( https://github.com/douglascrockford/JSLint/issues/67 ). I tried it on the inspector project but I guess that has changed in the interim and no longer contains the trigger code for the problem. The fix is once the error situation is reached, skip over the problem character rather than continuously spinning trying to process it. I cannot say for certain there will be other subsequent parse issues once this problem state has been reached, but at least it won't spin and lock up the editor. pull request is: https://github.com/eclipse/orion.client/pull/12 I know the longer term plan is upgrade jslint, but I created this to maybe help in the interim. === I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
(In reply to comment #5) > I've created a pull request for a patch that might address this in the current > JSLint we are using - it addresses the referenced bug ( > https://github.com/douglascrockford/JSLint/issues/67 ). I tried it on the > inspector project but I guess that has changed in the interim and no longer > contains the trigger code for the problem. The fix is once the error situation > is reached, skip over the problem character rather than continuously spinning > trying to process it. I cannot say for certain there will be other subsequent > parse issues once this problem state has been reached, but at least it won't > spin and lock up the editor. > > pull request is: https://github.com/eclipse/orion.client/pull/12 > > I know the longer term plan is upgrade jslint, but I created this to maybe help > in the interim. Hi Andy, I'm fine with your changes. The JSLint upgrade probably won't make it into 0.4, so let's commit this fix. There's one additional change we need though. In the header of jslintworker.js, after the line > NO WARRANTY EXPRESSED OR IMPLIED. USE AT YOUR OWN RISK. Can you add a section listing the contributors to the file, like this: > Contributors: > Douglas Crockford - Original implementation > Andy Clement - Fix for Bug #367639 Thanks!
I just added that additional change to the pull request, hope it is ok now.
(In reply to comment #7) > I just added that additional change to the pull request, hope it is ok now. Looks good. Pushed: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=7cdb1df648acc943ad9dcce2cc04e41de6c03a9f (I squashed the changes into one commit for clarity, but kept you as the Author.) Thanks Andy.
