367621 – ICodeAssist.codeSelect(int, int) returns incorrect result for inner class varargs (was: "Open Declaration" doesn't work correctly for inner class varargs)

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367621 - ICodeAssist.codeSelect(int, int) returns incorrect result for inner class varargs (was: "Open Declaration" doesn't work correctly for inner class varargs)

Summary: ICodeAssist.codeSelect(int, int) returns incorrect result for inner class var...

Status:	CLOSED WONTFIX

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	Core (show other bugs)
Version:	3.8
Hardware:	All All

Importance:	P3 minor (vote)
Target Milestone:	---
Assignee:	Ayushman Jain
QA Contact:

URL:
Whiteboard:	stalebug
Keywords:

Depends on:
Blocks:

Reported:	2011-12-29 07:48 EST by Philippe Marschall
Modified:	2019-09-09 14:15 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
sample code to reproduce the issue (380 bytes, text/x-java) 2011-12-29 07:49 EST, Philippe Marschall	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Philippe Marschall

2011-12-29 07:48:05 EST

Build Identifier: I20110915-1308

If you have an argument type that is an inner class then "Open Declaration" opens the type declaration, as you would expect. However if it's a vararg array of inner classes then "Open Declaration" does either nothing or takes you to a "normal" class declaration with the same name. Consider the attached Class

String → "Open Declaration" takes you to java.lang.String
String... → "Open Declaration" takes you to java.lang.String

Entry → "Open Declaration" takes you to java.util.Map.Entry<?, ?>
Entry... → "Open Declaration" does nothing

Modifier → "Open Declaration" takes you to java.nio.file.WatchEvent.Modifier (Java 1.7)
Modifier... → "Open Declaration" offers you a choice between java.lang.reflect.Modifier and javax.lang.model.element.Modifier 

Reproducible: Always

Comment 1 Philippe Marschall

2011-12-29 07:49:36 EST

Created attachment 208843 [details]
sample code to reproduce the issue

Comment 2 Deepak Azad

2011-12-30 02:47:54 EST

Essentially org.eclipse.jdt.core.ICodeAssist.codeSelect(int, int) calls in the following 2 methods return the incorrect result

org.eclipse.jdt.internal.ui.actions.SelectionConverter.codeResolve(IJavaElement, ITextSelection)
org.eclipse.jdt.internal.ui.javaeditor.JavaElementHyperlinkDetector.detectHyperlinks(ITextViewer, IRegion, boolean)

Note that the type binding in the AST is correct. Moving to JDT/Core.

Comment 3 Ayushman Jain

2012-01-03 04:25:32 EST

I will take a look.

Comment 4 Dani Megert

2012-01-03 05:58:59 EST

See also bug 291040.

Comment 5 Eclipse Genie

2019-09-09 14:15:29 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.