Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367605 - [refactoring] missing update of base import during renaming or moving a base class
Summary: [refactoring] missing update of base import during renaming or moving a base ...
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 2.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 2.2 M2   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 356003
  Show dependency tree
 
Reported: 2011-12-28 12:39 EST by Stephan Herrmann CLA
Modified: 2012-12-18 19:19 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-12-28 12:39:12 EST 
From bug 316698 comment 1: a base import is not updated when the
base class is renamed or moved to a different package.
Comment 1 Stephan Herrmann CLA 2011-12-28 13:11:30 EST 
The cause was:
missing override for Parser.consumeSingleBaseImportDeclarationName()
inside ImportMatchLocatorParser => base imports where not matched.

Test & fix have been released for 2.1 M5 via commit
dffa4e9d39d4434e5918e783e0e4a60221ed1bb5

The commit also contains analogous updates for CompletionParser
and DocumentElementParser.
Comment 2 Stephan Herrmann CLA 2012-09-22 14:11:44 EDT 
Using build 2.2.0.201209221349 this works for class renaming, but not when moving to another package.
Comment 3 Stephan Herrmann CLA 2012-09-22 15:45:44 EDT 
The move part has been fixed via commit 7b935330763aeaf767b983d7fde5bf4a764b0193
Comment 4 Stephan Herrmann CLA 2012-12-18 19:19:04 EST 
While bug 382185 can still be reproduced, this current bug has been verified using 2.2M4.