Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367564 - JdtClasspathUriResolver optimization
Summary: JdtClasspathUriResolver optimization
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.3.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-27 01:17 EST by Vladimir Piskarev CLA
Modified: 2017-09-19 17:05 EDT (History)
1 user (show)

See Also:
sven.efftinge: juno+

Attachments
Proposed patch (6.63 KB, patch)
2011-12-27 01:19 EST, Vladimir Piskarev CLA 		sven.efftinge: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Piskarev CLA 2011-12-27 01:17:49 EST 
Build Identifier: 2.2.1

Profiling showed a hot path in ExtensibleURIConverterImpl#normalize(URI) due to JdtClasspathUriResolver#findResourceInWorkspace(IJavaProject, URI) method. As currently implemented, this method has a costly resource traversal (via IResourceVisitor) which can be completely optimized away via obtaining an IFile handle and checking for file existence. Please see the proposed patch which proved to speed up build quite a bit on a project with 5000 'entities' having a validator similar to Xtend2's ClasspathBasedChecks.

Reproducible: Always
Comment 1 Vladimir Piskarev CLA 2011-12-27 01:19:15 EST 
Created attachment 208809 [details]
Proposed patch
Comment 2 Sven Efftinge CLA 2012-01-24 05:11:52 EST 
pushed to master
Comment 3 Karsten Thoms CLA 2017-09-19 16:54:15 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 4 Karsten Thoms CLA 2017-09-19 17:05:06 EDT 
Closing all bugs that were set to RESOLVED before Neon.0