Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367518 - Sometimes tree nodes are not expanded after asynchronous update ("updating...")
Summary: Sometimes tree nodes are not expanded after asynchronous update ("updating...")
Status: RESOLVED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: GUI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Andrew Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-23 14:21 EST by Kevin Grigorenko CLA
Modified: 2012-01-23 14:37 EST (History)
0 users

See Also:

Attachments
Proposed fix (868 bytes, patch)
2011-12-23 14:23 EST, Kevin Grigorenko CLA 		andrew_johnson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Grigorenko CLA 2011-12-23 14:21:41 EST 
I can't tell if this is a timing condition or what, but sometimes when expanding a tree node, the "updating..." child will show up, but when it finishes, the parent node collapses and you have to expand the parent again to get the children. I can reproduce this consistently when re-opening a large dump, then doing "Show objects by class," and picking something common such as java.lang.String, and then expanding the first row.
Comment 1 Kevin Grigorenko CLA 2011-12-23 14:23:22 EST 
Created attachment 208786 [details]
Proposed fix

I'm not sure if this is the right solution, but it does fix the problem for me and doesn't seem to cause any side effects.

What seems to happen is that after disposing/removing all child items, the parent gets its "expanded" flag reset (presumably since there are no children, it can't be expanded). So I just save that off and reset it after the real children are added.
Comment 2 Andrew Johnson CLA 2012-01-12 05:43:14 EST 
I've found this hard to reproduce on Windows 7, even with a delay. It might have happened once. The fix seems sensible however, so I'll apply it.
Comment 3 Andrew Johnson CLA 2012-01-23 10:29:01 EST 
Fix applied.
Comment 4 Kevin Grigorenko CLA 2012-01-23 14:37:31 EST 
(In reply to comment #3)
> Fix applied.

Thanks.