Community
Participate
Working Groups
I20111221-2230 - Do an operation that fails - Do an operation that succeeds -> The progress icon still shows an error. This makes it look like the second operation failed. I think it should show the status of the last operation...
Created attachment 208750 [details] Screen shot
Progress icon shows error whenever there is at least one failure on the list. Finished tasks are removed from the list after about 5 minutes. What you propose is actually easier to implement, but based on some offline discussions with Szymon and Tomek I see this is not obviously better. Let's assume you have two operations running at the same time. One failed another one was successful. In some circumstances if the failed one finished few seconds earlier you'll have a "blink" of fail and then it'll be changed to icon without decorator. The good thing is that your attention should still be drawn to the failure anyway, because on tasks tooltip pops up and you can read the error message. Current approach is copied from old Eclipse so this is another reason to leave it as it is, but still something here isn't right, because even I get confused with this error decoration. Last week I made a change that should decrease a number of failed operations in the list ("Auth fail" tasks are removed when task is renewed with correct credentials), so maybe this will change a feeling of the process. Szymon opened a bug to be able to remove operations directly from the popup, so this may also make a difference. I think it's a good idea to postpone fixing this bug for a week and check if it's really still an issue.
I still felt it a little annoying so I did the following: * I divided operations in the popup to two categories: operations running on this page and operations running on other pages * Only operations running on this page change the icon * If there are operations currently running icon is changed to running * If there are no operations running now icon changes its status based on the last operation that changed state (so if last operation failed the icon shows error, but if there are error but last operations was successful icon has no decoration) * If last operation was removed icon has no decoration (if previous operation failed we don't change the state back to error, because we assume that user's attention has already be driven to it previously) * If we have two operations running parallelly than only the last finished changes the icon, but you'll still get a popup when the first one fails. This is maybe not ideal, but it's the best way to handle it without keeping an error icon all the time. Hopefully it'll make everyone's like easier.
