Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367400 - "button" style renders href commands as buttons too
Summary: "button" style renders href commands as buttons too
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 359621
  Show dependency tree
 
Reported: 2011-12-22 04:39 EST by Szymon Brandys CLA
Modified: 2011-12-22 15:46 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-12-22 04:39:38 EST
See attachment 208723 [details]. The new "button" style looks very nice, however href commands are rendered as buttons too. There is no way to choose to open is a separate tab etc. Maybe we should render href commands the old way, even if "button" style is used?
Comment 1 Susan McCourt CLA 2011-12-22 11:48:15 EST
This was intentional.  
I even thought of putting links in the buttons but it's a rather odd convention.
We've had discussion about opening a tab for changing tasks so I wanted to see how this played, but I agree it's inconsistent with what we've done so far.

It's certainly simple to render it the old way.  I'd like to see what others think about it.
Comment 2 Susan McCourt CLA 2011-12-22 15:46:32 EST
I asked for opinions on today's status call.
Agreement we need real anchor behavior.
Some discussion about whether to style anchors as buttons.

I tried the approach where we style anchors as buttons, and this worked, but then you start to wonder...should I style the text the anchor color?  how does the user know it's an anchor vs. not?  etc. etc.

So in the end, I think Szymon's suggestion is the correct one.  If it's a link, it should look like a link.  

It actually looks fine in the repositories view and can only look better in the new repo view.