Community
Participate
Working Groups
1. Open the editor on a file 2. Press Ctrl+Shift+M to hide the banner 3. Activate a command that needs parameters (Ctrl+L for example) 4. The parameter flyouts are not visible, so you can't really use the command.
it should be very simple to make the whole banner with slideout appear. After you enter the parameters, would you expect everything to disappear again?
(In reply to comment #1) I expected just the flyout to appear, with the rest of the banner still hidden. My mental model of the param flyouts for Find/Go To Line/etc is that they attach to the editor area, not the banner... so they'd be triggerable regardless of what state the banner is in. (Are these examples of "section commands" mentioned in [1]?) > it should be very simple to make the whole banner with slideout appear. After > you enter the parameters, would you expect everything to disappear again? Yes, and I'd be fine with that too. The main thing is being able to provide command input, and ending up back in the "hidden" state once I'm done. [1] http://wiki.eclipse.org/Orion/Page_Layout#Proposed_Layout
(In reply to comment #2) > (In reply to comment #1) > > I expected just the flyout to appear, with the rest of the banner still hidden. > My mental model of the param flyouts for Find/Go To Line/etc is that they > attach to the editor area, not the banner... so they'd be triggerable > regardless of what state the banner is in. (Are these examples of "section > commands" mentioned in [1]?) > [1] http://wiki.eclipse.org/Orion/Page_Layout#Proposed_Layout Yeah, your model matches closer with where we are going. The "header" is really the (mostly) static stuff related to the user, high level links, etc. Underneath we'll have task+resource related stuff which includes the commands. It makes sense that the slideout should go there, and then if we have multiple sections of content, the slideout could come out underneath the specific section. I just have to figure out how to accomplish the new layout in terms of border containers, etc. without having to change every single Orion page (or at least, make this the last time we change every single Orion page.)
This is fixed now for the editor (and I'm working on each page now.) The big change with the new header structure is that the "panes" (such as editor and outliner) now have their own toolbars, and the slideout is implemented for the pane toolbar. So when you maximize the editor, the toolbar stays there and the slideout stays. I still need to implement this for all the pages, but since the editor is fixed, I'm closing this bug. (I currently have some compatibility code that generates a toolbar in the old position if there is not one in the page, and those pages are still working the old way. Working on updating them all.)
fixed.
