Community
Participate
Working Groups
0.4 M1 - Perform a search with multiple results - Expand some of the results - Click "Collapse All" -> The tree collapses, but the twistie icons don't change state. I will attach a screen shot.
Created attachment 208703 [details] Screen shot
i'll look at this, I think it's the tree table.
*** Bug 369101 has been marked as a duplicate of this bug. ***
Pushed a proposed fix to the remote branch: origin/bug367363 The problem is that in the past we've had the explorer renderer anticipate when the treetable might need to update expand/collapse visuals and pass in the classes needed to do so. This has always been a "leak" of knowledge from renderer back to the widget, because the widget doesn't care at all anywhere else how the renderer draws things. The fact that it "might need to add or remove an image class in certain situations" is bogus. As we've added more programmatic ways to alter the expand/collapse state, this has gotten messier. So I added a method in the common renderer for updating expand/collapse visuals and now the treetable calls this method on any programmatic expand or collapse. Since this is RC2, I elected not to clean up the bogus API. Opened bug 371543 to fix this later. So we are using a mix of techniques in the proposed fix to minimize risk/change. - we still use the old toggle API with the image classes and treetable does not call the new "updateExpandVisuals" from the toggle API - explorer-table doesn't pass image classes into refreshAndExpand anymore - the treetable now calls the new method for all programmatic expand/collapse, including refreshAndExpand. I don't think anyone uses the image class parameters anymore but I'm being paranoid and leaving the code in there for later removal. Libing, can you review?
by the way, this fix also fixes a symptom I've often noticed and apparently never opened a bug for: - expand a folder in the nav - reload the page - the expansion is remembered/performed but the twistie is wrong
I've reviewed the code and tested on both file navigator and search pages. +1.
pushed fix. thanks, Libing.
*** Bug 371651 has been marked as a duplicate of this bug. ***
