Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367290 - Javadoc of @Execute and @CanExecute are mixed up
Summary: Javadoc of @Execute and @CanExecute are mixed up
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 4.2 M5   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-21 05:52 EST by Missing name CLA
Modified: 2011-12-21 08:32 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Missing name CLA 2011-12-21 05:52:22 EST 
Build Identifier: 

The Javadoc of @Execute (org.eclipse.e4.core.di.annotations.Execute) is:

> Use this annotation to tag methods that determine if this object's {@link Execute} method can be called. The tagged method must return Boolean value.


The Javadoc of @CanExecute (org.eclipse.e4.core.di.annotations.CanExecute) is:

> Use this annotation to tag methods that need to be executed.


It should be the other way round.

Reproducible: Always

Steps to Reproduce:
1. Open http://dev.eclipse.org/viewcvs/viewvc.cgi/e4/org.eclipse.e4.ui/bundles/org.eclipse.e4.core.di/src/org/eclipse/e4/core/di/annotations/CanExecute.java
2. Open http://dev.eclipse.org/viewcvs/viewvc.cgi/e4/org.eclipse.e4.ui/bundles/org.eclipse.e4.core.di/src/org/eclipse/e4/core/di/annotations/Execute.java
3. Compare
4. Notice Javadoc is mixed up
Comment 1 Paul Webster CLA 2011-12-21 07:27:28 EST 
Just as an aside, if you are looking at our source you should be using git now.  See http://wiki.eclipse.org/Platform_UI/How_to_Contribute

I'll fix the javadoc, thanx for finding this.

PW
Comment 2 Paul Webster CLA 2011-12-21 08:32:56 EST 
released to master
PW