Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367194 - Did the order of view and toolbar creation change in 4.x?
Summary: Did the order of view and toolbar creation change in 4.x?
Status: CLOSED DUPLICATE of bug 511846
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-20 09:49 EST by Andrew Overholt CLA
Modified: 2019-08-12 14:00 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2011-12-20 09:49:03 EST 
In the Linux Tools Valgrind plugin, we create the view's toolbar programmatically based on which underlying Valgrind tool is selected.  This seems to be an issue in 4.x as the toolbar appears to get disposed after the view calls createPartControl.  Elliott (on CC) noticed this issue while investigating bug 366831.  To workaround the issue he changed the Valgrind view creation code to show the view before creating the toolbar actions.

Is this a bug or expected behaviour in 4.x?
Comment 1 Remy Suen CLA 2011-12-20 10:02:09 EST 
(In reply to comment #0)
> In the Linux Tools Valgrind plugin, we create the view's toolbar
> programmatically based on which underlying Valgrind tool is selected.  This
> seems to be an issue in 4.x as the toolbar appears to get disposed after the
> view calls createPartControl.

Yes, this happens in CompatibilityView. I don't remember the exact reason why we're doing this though.
Comment 2 Rolf Theunissen CLA 2019-08-12 14:00:03 EDT 
Marking as duplicate of Bug 511846, which has some more information.

*** This bug has been marked as a duplicate of bug 511846 ***