Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367174 - Warn if no system config is found
Summary: Warn if no system config is found
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-20 07:21 EST by Jan Koops CLA
Modified: 2012-09-23 07:22 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Koops CLA 2011-12-20 07:21:48 EST 
Build Identifier: 

In our enterprise setup we install msysgit on windows without adding git.exe to the PATH, as the installer suggests.
As a consequence jgit does not find the msysgit installation and the system config is not used by jgit/egit.

Workaround: Pass -Djgit.gitprefix=C:\path\to\ in eclipse.ini

Reproducible: Always

Steps to Reproduce:
1. Install msysgit without adding git.exe to PATH
2. Open git-preferences configuration->system settings is empty
3.
Comment 1 Jan Koops CLA 2012-01-23 03:20:38 EST 
The solution for bug 301775 adds a configuration for this, so the workaround is to browse for msysgit-gitconfig.
Comment 2 Matthias Sohn CLA 2012-02-27 03:38:39 EST 
Can we close this with https://git.eclipse.org/r/#/c/4430/ which was merged recently ?
Comment 3 Jan Koops CLA 2012-02-28 07:43:13 EST 
For us  https://git.eclipse.org/r/#/c/4430/ is sufficient, as we'll preconfigure this for our developers via the workspace.

I think it's still a problem for standard users:
They install msysgit with defaults, and e.g. go through a git tutorial. When they start using egit their config is silently ignored. egit could scan the windows registry for the msysgit uninstall key, the install location is noted there:
SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Git_is1\InstallDir

https://github.com/msysgit/msysgit/blob/devel/share/WinGit/helpers.inc.iss#L56


I'll leave it up to you to close this bug.
Comment 4 Robin Rosenberg CLA 2012-09-23 07:22:15 EDT 
I think https://git.eclipse.org/r/#/c/6436/ satisfies this