Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367133 - [CodeMirror] Inline support for codemirror
Summary: [CodeMirror] Inline support for codemirror
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-19 15:54 EST by Mark Macdonald CLA
Modified: 2012-01-20 15:37 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-12-19 15:54:26 EST 
It needs to be possible to use CodeMirror modes to provide styling for the editor in a scenario where you don't want the whole Orion platform.

For example, if you wanted to embed a Perl editor on a web page, you'd include the Orion editor, plus some shim that lets it consume codemirror modes, plus perl.js from CodeMirror.

This bug is for writing the shim.
Comment 1 Mark Macdonald CLA 2012-01-20 15:37:39 EST 
I'm going to mark this bug Fixed since CodeMirrorStyler [1] is working well enough to reuse CodeMirror modes for styling a stand-alone Orion TextView.

There is still an outstanding issue of hooking up the CodeMirror error style ("cm-error") to the annotation model. I've opened bug 369289 for that.


[1] See commit http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=06cc23207389c695be1b4a01ee3125461f5914b6, jsdoc http://orion.eclipse.org/jsdoc/symbols/orion.mirror.CodeMirrorStyler.html