Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 367123 - R4Eclipse preference cannot be saved if view is closed
Summary: R4Eclipse preference cannot be saved if view is closed
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-19 14:41 EST by Jacques Bouthillier CLA
Modified: 2012-01-24 17:46 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacques Bouthillier CLA 2011-12-19 14:41:33 EST 
When I tried to update the preference page for R4E but the R4E navigator view was closed, I get the following error. Also, the modified preference does not get updated either. In this case here, I removed one review group. from the list in the R4E preference view
org.eclipse.swt.SWTException: Widget is disposed
	at org.eclipse.swt.SWT.error(SWT.java:4282)
	at org.eclipse.swt.SWT.error(SWT.java:4197)
	at org.eclipse.swt.SWT.error(SWT.java:4168)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:468)
	at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:340)
	at org.eclipse.swt.widgets.Tree.getItems(Tree.java:3249)
	at org.eclipse.jface.viewers.TreeViewer.getChildren(TreeViewer.java:171)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalCollectExpandedItems(AbstractTreeViewer.java:1588)
	at org.eclipse.jface.viewers.AbstractTreeViewer.getExpandedElements(AbstractTreeViewer.java:1180)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.filters.HideDeltasFilterHandler.execute(HideDeltasFilterHandler.java:56)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:178)
	at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:247)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.navigator.ReviewNavigatorActionGroup.runHideDeltasFilterCommand(ReviewNavigatorActionGroup.java:608)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.navigator.ReviewNavigatorView.applyDefaultFilters(ReviewNavigatorView.java:746)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.preferences.R4EPreferencePage.performOk(R4EPreferencePage.java:861)
	at org.eclipse.jface.preference.PreferencePage.performApply(PreferencePage.java:432)
	at org.eclipse.jface.preference.PreferencePage$2.widgetSelected(PreferencePage.java:281)
Comment 1 Sebastien Dubois CLA 2011-12-20 16:09:36 EST 
Fixed by checking dispose state of the navigator view when changing preferences