Description Holger Voormann 2011-12-19 12:03:37 EST

At runtime Eclipse should not require any JavaServer pages compiler (JSPC). Currently, there is a dependency from org.eclipse.help.webapp to org.eclipse.equinox.jsp.jasper.registry which should be removed.

In org.eclipse.help.webapp the Ant script "buildJSPs.xml" was intended to pre-compile JavaServer pages (*.jsp) into Java (Servlet) classes (*.java) and then use the compiled byte code (*.class) at runtime (see bug 360465 comment 2 and steps to reproduce below).  

Benefits:
- smaller minimal application footprint of RCP applications with help (org.apache.jasper.glassfish_2.2.2.v201112011158.jar has 578 KB)
- help start-up time will be reduced


Steps to reproduce that the *.jsp files are used instead of the precompiled Java Servlet byte code (in Eclipse 3.7.1 and N20111218):

1. Before launching Eclipse: in org.eclipse.help.webapp JAR archive in advanced/toolbar.jsp change

   BODY {
       background:<%=prefs.getToolbarBackground()%>;

to

   BODY {
       background:<%="r"+"ed"%>;

2. Launch Eclipse and open the help window: Help > Help Contents

Is: background color of the TOC and main area toolbar is red

Should: background color of the toolbars should be gray as specified in pre-compiled org.eclipse.help.internal.webapp.jsp.advanced.toolbar_jsp


Related bugs:
- bug 362724
- bug 360465
- bug 356887