Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366985 - MenuHelper#getIconURI() should be more specific when rewriting URLs
Summary: MenuHelper#getIconURI() should be more specific when rewriting URLs
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M5   Edit
Assignee: Brian de Alwis CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-16 16:21 EST by Brian de Alwis CLA
Modified: 2012-01-24 13:48 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian de Alwis CLA 2011-12-16 16:21:40 EST 
MenuHelper#getIconURI(ImageDescriptor) rewrites URIs extracted from a URLImageDescriptor to the more stable platform:/plugin form.  But it doesn't check that the URI is actually a form where this is applicable (i.e., a bundleentry: or bundleresource: URI).  It's not impossible that an icon could be fetched via the interwebs or specified as an RFC 2397-style data: URI.
Comment 1 Brian de Alwis CLA 2011-12-16 17:07:29 EST 
Fixed in commit 3712647d0c1d5e62d74283e898c269888a819d66:

Created new method, rewriteDurableURL(), to perform any required rewrites.
Comment 2 Brian de Alwis CLA 2012-01-24 13:47:58 EST 
Verified in I20120123-2200.
Comment 3 Brian de Alwis CLA 2012-01-24 13:48:22 EST 
Verified in I20120123-2200.