Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366943 - [Performance] Editors Memory leaks
Summary: [Performance] Editors Memory leaks
Status: CLOSED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.1   Edit
Hardware: All All
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: Cedric Dumoulin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 356837 368704 371604 371653 384145 384169
Blocks:
  Show dependency tree
 
Reported: 2011-12-16 08:59 EST by JBregnias CLA
Modified: 2013-04-18 15:40 EDT (History)
4 users (show)

See Also:

Attachments
the workaround for the patch (2.01 KB, patch)
2011-12-30 09:29 EST, Tristan Faure CLA 		no flags Details | Diff
the result of the memory leak analysis (32.24 KB, image/png)
2011-12-30 09:34 EST, Tristan Faure CLA 		no flags Details
mylyn/context/zip (101.80 KB, application/octet-stream)
2012-02-29 10:37 EST, Tristan Faure CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description JBregnias CLA 2011-12-16 08:59:50 EST 
Using papyrus editors for one day causes that the platform memory is bigger than 800Mo, even if memory is necessary from others applications (not a jvm problem).
Comment 1 Tristan Faure CLA 2011-12-30 09:29:41 EST 
Created attachment 208870 [details]
the workaround for the patch
Comment 2 Tristan Faure CLA 2011-12-30 09:34:25 EST 
Created attachment 208872 [details]
the result of the memory leak analysis
Comment 3 Tristan Faure CLA 2011-12-30 09:36:02 EST 
The problem comes from a dispose problem
for developers :
when a tab is closed the different papyrus parts (inheriting from AbstractPart) are correctly updated and the closed one is disposed.

when the "close current file" action is performed the different dispose methods are not closed because there is no links between the CTabItem (correctly disposed) and the diagram editor.

the patch i attach provides a simple work around but it does not completely fix the memory leak.
Cedric do you have any clue to provide a better way to fix this ?

I attache too, one screenshot corresponding to the leak analysis the work around applied to the sources

we are very concerned about this bug and I set a priority P1 to it.
Comment 4 Tristan Faure CLA 2012-02-29 10:37:42 EST 
Created attachment 211811 [details]
mylyn/context/zip

context of commit
Comment 5 Tristan Faure CLA 2012-02-29 10:37:53 EST 
commited Cedric Dumoulin modifications to the 0.8.X branch
Comment 6 Mathieu Velten CLA 2012-08-24 04:35:26 EDT 
memory leak in the DiagramEventBroker : some editpolicies are registering themselves as listeners but never unregistered in the deactivate.
Comment 7 Mathieu Velten CLA 2012-08-24 05:27:33 EDT 
fixed on 0.8.X-EYY and trunk.