Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366920 - Jubula Juno Compatibility - all context menus are enabled
Summary: Jubula Juno Compatibility - all context menus are enabled
Status: CLOSED FIXED
Alias: None
Product: Jubula
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: Juno M5   Edit
Assignee: Project Inbox CLA
QA Contact: Oliver Goetz CLA
URL:
Whiteboard:
Keywords:
Depends on: 367094
Blocks:
  Show dependency tree
 
Reported: 2011-12-16 03:30 EST by Markus Tiede CLA
Modified: 2012-02-09 05:18 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Tiede CLA 2011-12-16 03:30:08 EST 
All context menus in the views and editors are enabled - though the menu bar enablement for the corresponding handlers seems to be correct.
Comment 1 Markus Tiede CLA 2011-12-19 05:20:58 EST 
At this point we make use of programmatic CommandContributionItem().
Comment 2 Paul Webster CLA 2011-12-19 07:26:48 EST 
Could you link me to one of your Contribution factories?  http://dev.eclipse.org/viewcvs/viewvc.cgi/ or http://git.eclipse.org/c/ if that's where it is available?

PW
Comment 3 Paul Webster CLA 2011-12-19 07:28:03 EST 
I see you've blocked a 4.2 (Juno) bug, but this is targetted at Indigo?

PW
Comment 4 Markus Tiede CLA 2011-12-19 07:42:57 EST 
The target milestone has been corrected.

We programmatically create CommandContributionItems in one of our helper classes:

http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/tree/org.eclipse.jubula.client.ui/src/org/eclipse/jubula/client/ui/utils/CommandHelper.java#n156

All of our programmatically created contributions are present in the UI but their UI enablement state is incorrect (all items are always enabled).
Comment 5 Paul Webster CLA 2011-12-19 10:45:03 EST 
(In reply to comment #4)
> We programmatically create CommandContributionItems in one of our helper
> classes:
> 

Thank you Markus, that linked helped.  It looks like your CCI creation is pretty standard.  But since that bug referenced means no menu items should show up, I'm not sure how relevant it is.  How are these being contributed?

PW
Comment 6 Markus Tiede CLA 2011-12-19 11:03:40 EST 
I filed a new bug 367094 for this enablement issue as it indeed has no direct relation to the unsupported contribution factories.

A typical way of contributing these items can be found at

http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/tree/org.eclipse.jubula.client.ui.rcp/src/org/eclipse/jubula/client/ui/rcp/views/TestSuiteBrowser.java#n157
Comment 7 Oliver Goetz CLA 2012-02-09 05:18:32 EST 
I tested this issue using Juno M5 Eclipse for Testers. Context menu entries now are only enabled if the corresponding action is possible to perform (e.g. create new TS in TSB is disabled if you haven´t started a project yet). This ticket is linked to https://bugs.eclipse.org/bugs/show_bug.cgi?id=367094 which is verified fixed. I verified the fix using Juno M5. Closing this ticket.