Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366916 - [jface] GraphViewer does not handle post selection events
Summary: [jface] GraphViewer does not handle post selection events
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Zest (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-16 02:43 EST by Erdal Karaca CLA
Modified: 2011-12-18 18:24 EST (History)
1 user (show)

See Also:

Attachments
Initial post selection events notification. (864 bytes, patch)
2011-12-16 02:50 EST, Erdal Karaca CLA 		steeg: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erdal Karaca CLA 2011-12-16 02:43:01 EST 
The GraphViewer does not handle post selection events. This is needed e.g. by the eclipse properties view.
Comment 1 Erdal Karaca CLA 2011-12-16 02:50:10 EST 
Created attachment 208481 [details]
Initial post selection events notification.

I am not sure if this is the right place for post selection events notifications. But that makes the properties view work as expected.
Comment 2 Erdal Karaca CLA 2011-12-16 02:53:52 EST 
BTW. I am not sure why you define your own listener lists as the base Viewer classes already have an attribute to collect the listeners.
Specifically, I would have thought that you would be reusing e.g.

- StructuredViewer.postSelectionChangedListeners
- Viewer.selectionChangedListeners
Comment 3 Fabian Steeg CLA 2011-12-18 18:24:21 EST 
Thanks for the patch.

Fixed in 2.0 master and 1.x HEAD, see GraphViewerTests#testPostSelectionListener