Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366858 - Minimum bundle dependencies shall reflect recent structural changes
Summary: Minimum bundle dependencies shall reflect recent structural changes
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 trivial (vote)
Target Milestone: 3.7   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 371599
  Show dependency tree
 
Reported: 2011-12-15 13:53 EST by Alvaro Sanchez-Leon CLA
Modified: 2012-02-15 06:06 EST (History)
2 users (show)

See Also:


Attachments
eclipse failing to start (57.02 KB, application/octet-stream)
2011-12-15 13:56 EST, Alvaro Sanchez-Leon CLA
no flags Details
List of updated Mylyn Bundles (192.33 KB, image/jpeg)
2011-12-15 14:06 EST, Alvaro Sanchez-Leon CLA
no flags Details
Showing Tasks Ui not updated to latest (317.63 KB, image/jpeg)
2011-12-15 14:06 EST, Alvaro Sanchez-Leon CLA
no flags Details
mylyn/context/zip (6.38 KB, application/octet-stream)
2011-12-17 08:29 EST, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2011-12-15 13:53:13 EST
I am experiencing a problem which seems to be coming from the recent re-factorings i.e. Bug 360301, Bug 350385 and Bug 305782

  After installing latest Mylyn Reiews, the Eclipse installation is not starting and is complaining of a class not found exception, so the TasksUIPlugin can not be started.

Caused by: java.lang.NoClassDefFoundError: org/eclipse/mylyn/internal/tasks/core/notifications/Environment
	at java.lang.Class.getDeclaredConstructors0(Native Method)
	at java.lang.Class.privateGetDeclaredConstructors(Class.java:2389)
	at java.lang.Class.getConstructor0(Class.java:2699)
	at java.lang.Class.newInstance0(Class.java:326)
	at java.lang.Class.newInstance(Class.java:308)
	at org.eclipse.osgi.framework.internal.core.AbstractBundle.loadBundleActivator(AbstractBundle.java:166)
	... 69 more     

Looking at the latest changes in Tasks core, it can be seen that the class above was removed from o.e.m.tasks.core 
  However the upgraded installation picked up the new tasks.core plug-in but not the latest o.e.m.tasks.ui plug-in.

Looking at the o.e.mylyn.taks.ui manifest, it specifies dependencies to o.e.m.tasks.core [3.0.0, 4.0.0).  

I think the minimum dependency should now be moved to 3.7
so the latest tasks.ui gets loaded as well.

A separate task shall also be raised to make sure Mylyn Versions and Mylyn Reviews introduce dependencies at the feature level to make the propagation of dependencies more robust.
Comment 1 Alvaro Sanchez-Leon CLA 2011-12-15 13:56:40 EST
Created attachment 208464 [details]
eclipse failing to start
Comment 2 Alvaro Sanchez-Leon CLA 2011-12-15 14:06:03 EST
Created attachment 208465 [details]
List of updated Mylyn Bundles
Comment 3 Alvaro Sanchez-Leon CLA 2011-12-15 14:06:44 EST
Created attachment 208466 [details]
Showing Tasks Ui not updated to latest
Comment 4 Alvaro Sanchez-Leon CLA 2011-12-15 14:39:47 EST
On the same discussion, it seems
org.eclipse.mylyn-feature needs to replace the dependency to o.e.mylyn.commons.core bundle to o.e.m.commons-feature
Comment 5 Steffen Pingel CLA 2011-12-17 08:29:29 EST
Thanks for pointing that out. I have changed the version constraints in all framework bundles to require version 0.9.0 or 3.7.0 or higher of other Mylyn bundles.

I am not sure why you encountered this error. It seems that the updated notifications bundle did get installed but since there are several versions of some bundles Eclipse may have loaded the wrong combination of versions. The changes I made and restructured Mylyn commons features should avoid this scenario in the future.
Comment 6 Steffen Pingel CLA 2011-12-17 08:29:32 EST
Created attachment 208515 [details]
mylyn/context/zip