Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366855 - MenuHelper.getIconURI() has no provision for non-File- or URL-based imagedescriptors
Summary: MenuHelper.getIconURI() has no provision for non-File- or URL-based imagedesc...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M5   Edit
Assignee: Brian de Alwis CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-15 13:32 EST by Brian de Alwis CLA
Modified: 2012-01-24 13:56 EST (History)
1 user (show)

See Also:

Attachments
Patch to MenuHelper (5.21 KB, patch)
2011-12-15 13:32 EST, Brian de Alwis CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian de Alwis CLA 2011-12-15 13:32:51 EST 
Created attachment 208463 [details]
Patch to MenuHelper

Build: 4.2M4

I have an editor that adds actions to the toolbar.  These actions are actually wrapped instances of Swing/AWT Action objects, and have a custom ImageDescriptor that wraps a Swing IconImage.  Although this ImageDescriptor actually has a URL, but MenuHelper#getIconURI() specifically only handles FileImageDescriptor and URLImageDescriptor.  As a result, the actions are treated as if it has no icon, and the action text is shown instead.

I think we should enhance MenuHelper#getIconURI() to use the adapter manager framework, so as to provide an opportunity for non-{File,URL}ImageDescriptors to provide a URL/URI.
Comment 1 Brian de Alwis CLA 2011-12-16 17:07:38 EST 
Fixed in commit d533f63b331c66c0efaf2432d0dbccbb125f7ee4:

Add code to use IAdaptable/IAdapterManager to adapt the ImageDescriptor to a URL.
Comment 2 Brian de Alwis CLA 2012-01-24 13:56:57 EST 
Verified in I20120123-2200.