Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 366847 - search fails in some cases
Summary: search fails in some cases
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Server (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-15 12:48 EST by Felipe Heidrich CLA
Modified: 2011-12-19 14:01 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felipe Heidrich CLA 2011-12-15 12:48:17 EST 
1. have org.eclipse.orion.client checkout.
2. in the navigator page search for the term createFrame
3. the result page says no matches (bug)
4. open org.eclipse.orion.client/bundles/org.eclipse.orion.client.editor/web/orion/textview/textView.js
5. file search (ctrl+f) for createFrame, you will find 2 occurrences.
Comment 1 John Arthorne CLA 2011-12-19 09:58:33 EST 
I think the leading underscore on _createFrame must be causing it. I am investigating.
Comment 2 Ken Walker CLA 2011-12-19 10:09:44 EST 
Similar or dupe of https://bugs.eclipse.org/bugs/show_bug.cgi?id=366212 ?
Comment 3 libing wang CLA 2011-12-19 10:45:36 EST 
(In reply to comment #2)
> Similar or dupe of https://bugs.eclipse.org/bugs/show_bug.cgi?id=366212 ?

I think it is similar but the root cause may be the same.
The difference is that searching on "_createFrame" does not hit anything but on "_selection" it hits something irrelevant, where it causes 0 match.
Comment 4 John Arthorne CLA 2011-12-19 11:33:26 EST 
Finally tracked this down. The problem was the Solr configuration had a default maximum field size of 10000 characters. Anything past roughly line 1500 of textView.js wasn't being indexed at all. I have bumped this up by 10x and now createFrame is being found for me.

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=eb372dba428eaac0a7ed39b4471f9210fa763f2d
Comment 5 John Arthorne CLA 2011-12-19 14:01:32 EST 
Fix pushed.